Add read support for handles with pending payloads #24320
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area: dds
There was a problem hiding this comment.
Copilot reviewed 17 out of 17 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (2)
packages/runtime/container-runtime/src/blobManager/blobManager.ts:365
- Consider adding a default value for the 'placeholder' parameter (e.g., 'placeholder: boolean = false') to simplify calling this function in contexts where a placeholder is not explicitly needed.
public async getBlob(blobId: string, placeholder: boolean): Promise<ArrayBufferLike> {
packages/runtime/runtime-utils/src/remoteFluidObjectHandle.ts:38
- [nitpick] It would be helpful to add inline documentation for the 'placeholder' parameter to clarify its purpose and expected use across clients.
public readonly placeholder: boolean,
packages/runtime/container-runtime/src/summary/documentSchema.ts
Outdated
Show resolved
Hide resolved
anthony-murphy
approved these changes
Apr 15, 2025
ChumpChief
commented
Apr 22, 2025
scottn12
reviewed
Apr 24, 2025
|
🔗 No broken links found! ✅ Your attention to detail is admirable. linkcheck output |
anthony-murphy
approved these changes
Apr 24, 2025
ChumpChief
changed the title
markfields
pushed a commit
to markfields/FluidFramework
that referenced
this pull request
Apr 24, 2025
Adds: 1. DocumentSchema support for the new schema flag, such that these readable clients won't blow up once the future write-mode-capable clients turn the flag on 2. ContainerRuntime/BlobManager support for waiting on blobs to appear if their handles are tagged with `payloadPending` [AB#36250](https://dev.azure.com/fluidframework/235294da-091d-4c29-84fc-cdfc3d90890b/_workitems/edit/36250)
jason-ha
reviewed
Apr 25, 2025
| @@ -1588,6 +1588,7 @@ describe("Runtime", () => { | |||
| enableRuntimeIdCompressor: undefined, | |||
| enableGroupedBatching: true, // Redundant, but makes the JSON.stringify yield the same result as the logs | |||
| explicitSchemaControl: false, | |||
| createBlobPayloadPending: false, // Redundant, but makes the JSON.stringify yield the same result as the logs | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the read portion of placeholder handles for blobs (as prototyped in #24158). It specifically adds:
placeholderGetting this up now for consideration but I'm still looking into an oddity in interactions between this read-only support and the full prototype version that I need to iron out - something weird happening when the full prototype tries to upgrade the document schema.Determined the oddities were an unrelated bug.AB#36250